Push test code lens to response builder on test discovery #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
05-06-push_test_code_lens_to_response_builder_on_test_discovery
branch
from
99604f5 to
1741456
Compare
vinistock
force-pushed
the
05-06-upgrade_ruby_lsp_dependency_to_v0.23.17
branch
from
ceede43 to
28a9f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Shopify/ruby-lsp#3449
This PR makes use of the new API to associate code lenses with discovered test items, so that the IDs match as expected.
All we need to do is push the test item as a code lens during test discovery and avoid doing the duplicate work in
CodeLensitself.