-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Added tests and workflow to run tests on release and PRs #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shazron , Could you please take a look at the above? |
@shazron , Did you get a chance to review the above? |
@Rachit1313 sorry, I've been occupied but I will review soon later this week. |
You can check the result of the workflow runs: no coverage files were generated. Please add the right flags to generate them so codecov can parse them. |
…to generate coverage using nyc
Hi @shazron , |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
The code changes are ok, but coverage is only 37.25% according to Codecov. The threshold for all our repos is 100%: https://github.com/adobe/aio-cli-plugin-app/blob/f27eaafad21231a9288660c8f67c2860d2b2c304/jest.config.js#L26-L31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage must be 100%
closing, incomplete. we will proceed with our own tests |
Description
This pull request addresses the following changes:
@adobe/[email protected]
workflow.CreateAioLibCommand
methods, includingcopyTemplate
,cloneRepo
,removeDotGitFolder
,readParametersFile
, andupdatePackageJson
.Related Issue
#103Motivation and Context
How Has This Been Tested?
These changes have been tested using the following steps:
@adobe/[email protected]
test workflow usingmocha tests/unit
.CreateAioLibCommand
functionality.Screenshots (if appropriate):
Types of changes
Checklist: