fix(@schematics/angular): remove explicit index option from new applications #30192
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
ng-new/default-index
branch
2 times, most recently
from
35077d3 to
ad5d672
Compare
…cations With the index option now defaulting to `<project_source_root>/index.html` for the `application` build system, the explicit value present in new applications is no longer required. This removal further reduces the size of the `angular.json` file for new projects.
The `@angular/pwa` add schematic now attempts to discover a default index option value if a configuration usage path within the build target is possible. The default value as per the `application` build system is `<project_source_root>/index.html`.
clydin
force-pushed
the
ng-new/default-index
branch
from
ad5d672 to
4968791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the index option now defaulting to
<project_source_root>/index.htmlfor theapplicationbuild system, the explicit value present in new applications is no longer required. This removal further reduces the size of theangular.jsonfile for new projects.