Fail Fast if Resources Do Not Exist in Kafka Cluster. #34659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozzie15
force-pushed
the
kafka_failfast_bugfixes
branch
3 times, most recently
from
4da28e6 to
5f038ad
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
LGTM |
Dippatel98
approved these changes
Apr 23, 2025
|
R: @johnjcasey for final approval |
fozzie15
force-pushed
the
kafka_failfast_bugfixes
branch
4 times, most recently
from
6313f99 to
0f1f8f1
Compare
johnjcasey
reviewed
Apr 24, 2025
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
Show resolved
Hide resolved
| consumer.partitionsFor(providedTopic).stream() | ||
| .map(PartitionInfo::partition) | ||
| .collect(Collectors.toSet()); | ||
| if (spec.getLogTopicVerification() == null || !spec.getLogTopicVerification()) { |
There was a problem hiding this comment.
we could simplify these checks by defaulting the value to false
There was a problem hiding this comment.
Leaving as a TODO for now as mentioned offline. If its not super important we can merge as is, otherwise I'll revisit this next week.
fozzie15
force-pushed
the
kafka_failfast_bugfixes
branch
from
0f1f8f1 to
321e52d
Compare
fozzie15
force-pushed
the
kafka_failfast_bugfixes
branch
from
321e52d to
19a58c0
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix and reintroduction of #34258.
ORIGINAL DESCRIPTION: If a specified topic or partition do not exist in a kafka cluster, the pipeline should fail before submission. There are some caveats to this, such as whether or not the cluster is reachable, so we only fail in the case where the cluster is reachable but the specified partitions or topics are not present.
This PR also adds a new change to address #34630 which details an error if the local machine cannot connect to the cluster during verification steps. The error is no longer thrown and a new test case has been added to verify this issue no longer happens.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.