-
Notifications
You must be signed in to change notification settings - Fork 280
Add Python version 3.13 to test matrix. #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add Python version 3.13 to matrix.
Python Rust binding maximum supported version (3.12)
|
@JE-Chen Thanks for checking. It looks like Py3O is already at 3.13: PyO3/pyo3#4636 I was hoping that maybe bumping the Poetry build might fix it #1379. Could you rebase? Otherwise we have to track which dependency is still locked at this older version of Py3O. |
Add Python version 3.13 to matrix.
… into test_matrix
Done |
Same error.
|
Currently, we are using pyo3 v0.20.3. I think only versions of pyo3 v0.21 or newer support Python 3.13. |
* add * fix mkdoc
* Drop upper bounds for fsspec and it's implementations * Run poetry lock
* Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog (apache#1331) * Use TABLE_TYPE --------- Co-authored-by: Wenzhuo Zhao <[email protected]>
* fix Table.name * replace Table.identifier with Table.name * add warning filter
* Update parser.py Allow leading underscore in column name used in row filter. * Update test_parser.py * Update test_parser.py * Update test_parser.py
* Remove Python 3.13 upper bound restriction * Fix missing poetry.lock file * Upgrading numpy on the poetry.lock file from v1.26.0 to v1.26.4
* initial update * edits * add gpg instructions * verify artifacts * add twine not * grammar * edits * remove old artifacts * update doc workflow action * and name * add docs on patch vs major/minor release
…olumn stats (apache#1354) * fix KeyError, by switching del to pop * added unit test * update test * fix python 3.9 compatibility, and refactor test * update test
* add instruction for patch release * create branch from tag
@JE-Chen I think it pulls |
Looks like we're still pinning on an older version of |
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.4 to 7.6.5. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.6.4...7.6.5) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocstrings](https://github.com/mkdocstrings/mkdocstrings) from 0.26.2 to 0.27.0. - [Release notes](https://github.com/mkdocstrings/mkdocstrings/releases) - [Changelog](https://github.com/mkdocstrings/mkdocstrings/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/mkdocstrings@0.26.2...0.27.0) --- updated-dependencies: - dependency-name: mkdocstrings dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.5 to 7.6.7. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.6.5...7.6.7) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: aiohttp dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [moto](https://github.com/getmoto/moto) from 5.0.20 to 5.0.21. - [Release notes](https://github.com/getmoto/moto/releases) - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@5.0.20...5.0.21) --- updated-dependencies: - dependency-name: moto dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove deprecated datetime functions * remove all usage of deprecated methods * readd utcnow filter because of boto3
Fixing conflicts to see where we are with 3.13 :) |
8bb7745
to
7a78748
Compare
7a78748
to
733735b
Compare
Blocked on Ray 3.13 ray-project/ray#49738 We can run |
It looks like there is some progress: ray-project/ray#49738 (comment) We should also bump the upper bounds when generating the wheels: https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20%3C3.13&type=code |
@JE-Chen Could you do another attempt? We've bumped to Ray 2.45, but the issue is still open 🤔 |
yep ray 2.45 has artifacts for python 3.13 https://pypi.org/project/ray/2.45.0/#files |
# Conflicts: # poetry.lock
Do I need to update this list? |
You dont need to change the content of the poetry.lock file directly, its generated by running Take a look at #1068 as an example. This is how we added 3.12 to the project |
Thanks for the information. So, I think I need to modify pyproject.toml. I will run pre-commit and poetry lock later. |
Add a new optional ray version: - If the Python version is ≥ 3.13, use a ray version that is ≥ 2.45.0.
Fix format (space)
After running poetry lock command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like these are the last 2 changes we'd need to make
https://grep.app/search?f.repo.pattern=iceberg-python&q=3.13
i suggestion <3.13
-> <=3.13
so that its easier for us to change the next time around
make install and re-run poetry lock
Add python 3.13 to pyproject.toml classifiers: "Programming Language :: Python :: 3.13",
Replace <3.13 with <=3.13
Looks like 3.13 gave us some extra warnings
https://alexwlchan.net/til/2025/python3-13-sqlite-warnings/ |
Fixes #1372
Add Python version 3.13 to matrix.