-
Notifications
You must be signed in to change notification settings - Fork 280
Apply residuals when reading a table #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f5b8eaf
to
569d1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I wonder if there's a good place to document this a little more (for future developers/for folks that use pyiceberg as reference implementation)
@corleyma Good point, I think most of the docs around residuals are here: iceberg-python/pyiceberg/expressions/visitors.py Lines 1737 to 1751 in e9d35d5
Any thoughts? |
No description provided.