Skip to content

[SPARK-51890][SQL] Add New Parameter options to Logical Plan View. #50645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yumingxuanguo-db
Copy link

@yumingxuanguo-db yumingxuanguo-db commented Apr 18, 2025

What changes were proposed in this pull request?

Adds a new parameter options: CaseInsensitiveStringMap to the case class of logical plan View. Changed a few pattern matching along the way.

Why are the changes needed?

User specified options when reading views can be stored for later use. I.e.,

SELECT * FROM view WITH (foo = bar)

Does this PR introduce any user-facing change?

Yes. The pattern matching on View now takes four arguments instead of three.

How was this patch tested?

UTs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Apr 18, 2025
@yumingxuanguo-db yumingxuanguo-db changed the title add new parameter option to views Add New Parameter options to Logical Plan View. Apr 21, 2025
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Apr 22, 2025

Mind adding a test and filing a JIRA please? see also https://spark.apache.org/contributing.html

@yumingxuanguo-db yumingxuanguo-db changed the title Add New Parameter options to Logical Plan View. [SPARK-51890][SQL] Add New Parameter options to Logical Plan View. Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants