Skip to content

Label section added, FCC frequency bands updated #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2024
Merged

Label section added, FCC frequency bands updated #1868

merged 2 commits into from
Apr 10, 2024

Conversation

jcarolinares
Copy link
Contributor

What This PR Changes

  • Label section added, FCC frequency bands updated

Contribution Guidelines

@jcarolinares jcarolinares requested a review from mcmchris April 10, 2024 10:53
mcmchris
mcmchris requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcarolinares , I suggested some unit changes in writing. Everything else, LGTM

@jcarolinares @mcmchris
Apply suggestions from code review
f44d588 
Co-authored-by: Christopher Méndez <[email protected]>
mcmchris
mcmchris approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jcarolinares
Copy link
Contributor Author

I will jump previews until I have an official solution, 20 minutes wasted waiting for it

@jcarolinares jcarolinares merged commit 2add5f8 into main Apr 10, 2024
3 of 4 checks passed
@jcarolinares jcarolinares deleted the jcarolinares/nicla-vision/certification-updates branch April 10, 2024 13:15
@jhansson-ard jhansson-ard added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmchris mcmchris mcmchris approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcarolinares @mcmchris @jhansson-ard