Fix broken links in content #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file targeted by the link no longer exists. I was not able to find a new source for the file. Since the link was not at all essential to the tutorial the best solution is to simply remove the link.
per1234
added
bug
jacobhylen
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Hej @per1234
I've had a look at all the changes that pertain to Maker boards, and it looks good to me :)
I'm adding @jcarolinares as a reviewer, to look at the changes in PRO docs.
Approval of the PR should come from him when he's checked it.
There was a problem hiding this comment.
Hello
Pro products reviewed and ready to go, only and additional suggestion to one of the changes and a comment regarding links that will change regarding step files.
@jacobhylen I let you the final approval
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-mid-carrier/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/shields/portenta-vision-shield/tutorials/connecting-to-ttn/content.md
Show resolved
Hide resolved
content/hardware/04.pro/shields/portenta-vision-shield/tutorials/connecting-to-ttn/content.md
Outdated
Show resolved
Hide resolved
...nt/hardware/04.pro/shields/portenta-vision-shield/tutorials/things-network-openmv/content.md
Show resolved
Hide resolved
...nt/hardware/04.pro/shields/portenta-vision-shield/tutorials/things-network-openmv/content.md
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-sense-me/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-voice/tutorials/user-manual/content.md
Show resolved
Hide resolved
The replacement URL points to the documentation for "The Things Stack" V3. Co-authored-by: Julián Caro Linares <[email protected]>
jacobhylen
approved these changes
Apr 18, 2024
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines
Fixes #1641
Related: https://forum.arduino.cc/t/docomentation-wrong-at-nano-33-ble-sense-rev2/1247165/3