This repository was archived by the owner on Apr 26, 2018. It is now read-only.
Fixes for activeresource 3.1 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to ActiveResource 3.1 breaks several features of this gem. Comments won't send anymore because the default is to send them as ..., while the API expects .... You cannot add locations to a person because the add locations post uses the URL /service/people/new/locations.xml rather than /service/people/123/locations.xml. The default encoding moves from XML to json. (I'm not sure if the encoding change created problems, but it certainly made it harder to debug and compare to the last version.)
I modified the library to address these bugs in my application. This probably isn't complete, as I only tested the APIs I use. Also, this version is not backward compatible with earlier activeresource versions. (I don't know if you'll want to try to harmonize the two of just have a different gem for later versions.) But I thought it would be useful to other folks facing the same problems, and might be a starting point to fixing the gem more generally.