-
Notifications
You must be signed in to change notification settings - Fork 177
⬆️ 💥 Replace dependency tightenco/collect by illuminate/collect… #3555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0486328
to
8fc938c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a BC break due to the namespace change. We need at the very least a note in the release document, as to what has changed, and I am at doubt whether we can merge this for 5.3.
Yes, but the update to Symfony 7 must introduce other namespace changes or BC break. From annotation to attribute is a BR Break? For Bolt 5.3, if this dependency is not migrated, the latest Symfony version is 6.4 from dependency requirements. |
5.3 won't be getting a Symfony upgrade for the same reason. |
Ok, this is why Symfony dependencies were removed from ticket 3551. It's Okay; all PR with BC Break can wait until after Bolt 5.3 to go to Bolt 6. Or a branch for Bolt 6 can be opened before Bolt 5.3 is released? |
53692ee
to
d80ed0d
Compare
The first focus is 5.3, and we can do for that without breaking BC. |
Replace dependency tightenco/collect by illuminate/collection
See issue #3551