Skip to content

lint: minor code clean to nwss #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2024
Merged

lint: minor code clean to nwss #1954

merged 4 commits into from
Apr 23, 2024

Conversation

dshemetov
Copy link
Contributor

Description

Was easier to just make a bunch of changes than to make review comments. It's mostly just code style lints that I preferred, happy to revert some pieces if you disagree. The actual important parts of the code seemed fine to me.

Changelog

  • Turn type_dict and type_dict_metric into global constants, remove constructor function
  • Remove a few simple functions
  • Change the schema change error message, inline the message
  • Add logger statement when df_concentration or df_metric contain columns not in TYPE_DICT or TYPE_DICT_METRIC

Fixes

To be merged into #1946

@dshemetov dshemetov requested a review from dsweber2 April 20, 2024 01:18
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. I think in the future it may just be better to push directly to the branch, since now I have enough suggestions that I could just as readily do a PR on this PR on the base PR, which seems... silly.

except KeyError as exc:
raise ValueError(warn_string(df_concentration, type_dict)) from exc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not clutter this function with repeated text when the contents of the warning don't really matter for this function. Definitely should be a KeyError though

@dsweber2 dsweber2 merged commit 8188bf7 into splittingNWSSSignals Apr 23, 2024
3 checks passed
@dshemetov dshemetov deleted the ds/nwss branch April 23, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants