Fix/note title composer #291
Open
+123
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
reviewed
Apr 7, 2025
e11sy
reviewed
Apr 14, 2025
src/repository/note.repository.ts
Outdated
| @@ -93,11 +92,11 @@ export default class NoteRepository { | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the Note tree by note id | |||
| * Fetches the raw recursive note tree data from DB | |||
| * Creates a tree of notes | ||
| * @param noteId - public note id | ||
| * @returns NoteHierarchy | ||
| * Fetches the raw recursive note tree data from DB |
e11sy
approved these changes
Apr 14, 2025
neSpecc
reviewed
Apr 16, 2025
| /** | ||
| * Note content | ||
| */ | ||
| content: NoteContent; |
There was a problem hiding this comment.
why there is a 'content' instead of 'title' like in NoteHierarchy entity
There was a problem hiding this comment.
This is the data we get from the database with the query and then change the content to title build the heirarchy structure and then return to frontend
There was a problem hiding this comment.
do we really need this type at all? Why not to use just Note entity like in other methods which returns a note from the database?
There was a problem hiding this comment.
Note entity dose not have parentId in it.
neSpecc
reviewed
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note title componser on backend.
Instead of note content now it should directely send note title
fixes: #287