Skip to content

[FEATURE] introduced tags #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

imdhruvgupta
Copy link
Contributor

Developed feature discussed in #18 .

@@ -36,6 +36,7 @@
"ember-cli-showdown": "^4.4.4",
"ember-cli-sri": "^2.1.0",
"ember-cli-uglify": "^2.0.0",
"ember-composable-helpers": "^2.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why include this? What helpers are we using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using 'pipe' helper in question/index/template.hbs for chaining multiple actions on a single event.

@abhishek97
Copy link
Contributor

@imdhruvgupta Looks Good!, However we need some UI to add tags too.

@abhishek97 abhishek97 merged commit a51d79c into coding-blocks:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants