Skip to content

move cz_conventional_commit defaults out of project wide default #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

ITingHung
Copy link
Contributor

@ITingHung ITingHung commented Mar 30, 2024

Description

commit_parser in commitizen/defaults.py is only for cz_conventional_commit rather than all commitizens. This PR is to move commit_parser from commitizen/defaults.py to conventional_commits.py

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

commit_parser in commitizen/defaults.py is removed, and will be directly retrieved from ConventionalCommitsCz.

Steps to Test This Pull Request

Additional context

Related to #818

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring. Will merge it once CI passes.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (120d514) to head (e3cfb09).
Report is 249 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   97.33%   97.52%   +0.19%     
==========================================
  Files          42       55      +13     
  Lines        2104     2429     +325     
==========================================
+ Hits         2048     2369     +321     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.52% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W changed the title refactor(defaults): move cz_conventional_commit defaults out of defau… move cz_conventional_commit defaults out of project wide default Mar 30, 2024
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Mar 30, 2024
@Lee-W Lee-W merged commit 7b49f8a into commitizen-tools:master Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants