-
-
Notifications
You must be signed in to change notification settings - Fork 281
style: move codespell configuration to pyproject.toml #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yarikoptic You'll need to run |
So people could just run "codespell" without pre-commit and have centralized configuration for tools (the others are already in pyproject.toml) Signed-off-by: Yaroslav Halchenko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
+ Coverage 97.33% 97.54% +0.20%
==========================================
Files 42 55 +13
Lines 2104 2487 +383
==========================================
+ Hits 2048 2426 +378
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yarikoptic According to the CI, it seems |
That's done, will need to fix up commit message now when wake up |
… is in pyproject.toml Signed-off-by: Yaroslav Halchenko <[email protected]>
done, green now |
Description
So people could just run "codespell" without pre-commit and have centralized configuration for tools (the others are already in pyproject.toml)
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testI did ;)