build(deps): remove importlib_metadata for Python >=3.10
#1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 55 +13
Lines 2104 2497 +393
==========================================
+ Hits 2048 2436 +388
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jakob-keller
changed the title
importlib_metadataimportlib_metadata for Python >=3.10
Lee-W
approved these changes
Jun 27, 2024
Lee-W
added
pr-status: ready-to-merge
|
This is great! I think we're good to merge but I will keep it for a few days so that others can take a look |
woile
approved these changes
Jun 27, 2024
|
hi @jakob-keller , could ou please help us relock the poetry.lock and then I'll merge it |
|
@jakob-keller Many thanks for your prompt help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
importlib.metadata as used by
commitizenwas first shipped with Python 3.10. The backport from importlib_metadata is only required for Python <3.10.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
commitizenno longer has a direct "runtime" dependency on theimportlib_metadatabackport for Python >=3.10, while using the backport for Python <3.10.Steps to Test This Pull Request
Additional context