Skip to content

docs: Allowed Prefixes default value typo #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

gbaian10
Copy link
Contributor

Description

The descriptions of the default values for allowed_prefixes are different on the Commands check and Configuration pages.

The capitalization of "Pull request" is inconsistent; in practice, "request" must be lowercase to allow skipping the check.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (120d514) to head (fa68132).
Report is 454 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   97.33%   97.66%   +0.33%     
==========================================
  Files          42       55      +13     
  Lines        2104     2575     +471     
==========================================
+ Hits         2048     2515     +467     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.66% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice finding! Thanks so much for your contribution!

@Lee-W Lee-W merged commit c95404b into commitizen-tools:master Oct 15, 2024
21 checks passed
@gbaian10 gbaian10 deleted the docs/allowed_prefixes_typo branch October 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants