Skip to content

build(pre-commit): migrate pre-commit conifg #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 10, 2024

Description

When running pre-commit run --all-files, the following error was encountered.

[WARNING] hook id `commitizen-branch` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `linter and test` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] top-level `default_stages` uses deprecated stage names (commit, push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.

This commit only only migrates the pre-commit config to the latest version.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Run pre-commit run --all-files without encountering warning

Steps to Test This Pull Request

Run pre-commit run --all-files

Additional context

When running `pre-commit run --all-files`, the following error was encountered.

```
[WARNING] hook id `commitizen-branch` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `linter and test` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] top-level `default_stages` uses deprecated stage names (commit, push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
```

This commit only only migrates the pre-commit config to the latest version.
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (120d514) to head (7116af5).
Report is 481 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   97.33%   97.57%   +0.24%     
==========================================
  Files          42       55      +13     
  Lines        2104     2602     +498     
==========================================
+ Hits         2048     2539     +491     
- Misses         56       63       +7     
Flag Coverage Δ
unittests 97.57% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W force-pushed the migrate-pre-commit-config branch from cc100d3 to 7116af5 Compare November 10, 2024 03:21
@woile woile merged commit e75b837 into master Nov 10, 2024
21 checks passed
@woile woile deleted the migrate-pre-commit-config branch November 10, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants