-
Notifications
You must be signed in to change notification settings - Fork 50
[coverage] Fix resume after shutdown error #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Pull Request Test Coverage Report for Build 14719582815Details
💛 - Coveralls |
Revisions updated by `dart tools/rev_sdk_deps.dart`. i18n (https://github.com/dart-lang/i18n/compare/de19436..e44af54): e44af54 2025-05-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/i18n#966) test (https://github.com/dart-lang/test/compare/3ac991f..c3755d8): c3755d80 2025-05-01 dependabot[bot] Bump github/codeql-action from 3.28.13 to 3.28.16 in the github-actions group (dart-lang/test#2492) 935b8b04 2025-04-28 Danny Tuppeny Allow specifying an explicit location for test/groups (dart-lang/test#2481) tools (https://github.com/dart-lang/tools/compare/11f4cf7..92f10a9): 92f10a9a 2025-04-30 Liam Appelbe [coverage] Fix resume after shutdown error (dart-lang/tools#2079) 7e8cb037 2025-04-29 Viral Verma Add --fail-under flag for minimum coverage threshold (dart-lang/tools#2075) web (https://github.com/dart-lang/web/compare/553c14d..f1becf0): f1becf0 2025-04-30 Natalie Weizenbaum Add conversions between Dart's Uri and the JS URL (dart-lang/web#365) Change-Id: Icc33983c9cc2cdad7add25494c92a21e8605b2a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425900 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Found another edge case where we attempt to resume an isolate after the VM service has shut down:
IsolatePausedListener._onIsolatePaused
is running for a non-main isolate, and is taking a whileThis causes an error to be thrown. The fix is just to not bother trying to resume the isolate in this case.
This fixes internal bug b/411490560.