FIX Assembly input for meshcloud Distance Calculation #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2024
9and3
reviewed
Aug 21, 2024
deps/pybind11
Outdated
There was a problem hiding this comment.
can you get our this from the PR to avoid conflicts please?
There was a problem hiding this comment.
okie. i deleted the folder in the last push. Let me know if there was a better way to take it out :)
| ghenv.Component.Message= f"Per Joint" | ||
| rh_mesh_target_list = [joint.to_mesh(i_analysis_resolution) for joint in i_assembly._all_joints] | ||
| else: | ||
| ghenv.Component.AddRuntimeMessage(RML.Warning, "The input number of obejcts to compare matches neither the number of beams nor the number of joints") |
There was a problem hiding this comment.
small typo in the runtime message ;)
|
Amazing merging this one so that we have a full pipeline to test! Thanks @eleniv3d ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the input of the DF_cloud_mesh_distance component from DFBeam to DFAssembly for consistency and should address issue #55 and issue #52
We decide whether to calculate joints or beams by comparing the length of the cloud source input list with the number of beams and joints in the assembly, and output a respective message
PR.mp4