Skip to content

FEATURE: forum researcher persona for deep research #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 14, 2025
Merged

Conversation

SamSaffron
Copy link
Member

@SamSaffron SamSaffron commented May 6, 2025

This commit introduces a new Forum Researcher persona specialized in deep forum content analysis along with comprehensive improvements to our AI infrastructure.

Key additions:

  • New Forum Researcher persona with advanced filtering and analysis capabilities
  • Robust filtering system supporting tags, categories, dates, users, and keywords
  • LLM formatter to efficiently process and chunk research results

Infrastructure improvements:

  • Implemented CancelManager class to centrally manage AI completion cancellations
  • Replaced callback-based cancellation with a more robust pattern
  • Added systematic cancellation monitoring with callbacks

Other improvements:

  • Added configurable default_enabled flag to control which personas are enabled by default
  • Updated translation strings for the new researcher functionality
  • Added comprehensive specs for the new components

This change makes our AI platform more stable while adding powerful research capabilities that can analyze forum trends and surface relevant content.

@SamSaffron SamSaffron force-pushed the researcher.rb branch 2 times, most recently from a10d1e9 to 84e9286 Compare May 8, 2025 04:11
@SamSaffron SamSaffron changed the title researcher.rb FEATURE: forum researcher persona for deep research May 13, 2025
@SamSaffron SamSaffron marked this pull request as ready for review May 13, 2025 07:18
Copy link
Member

@romanrizzi romanrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The CancelManager is a very nice improvement.

Something I have mixed feelings about is where the object is istantiated. I'd prefer it to bubble from the bottom like before this change, but we'd need a better completion response abstraction to properly support that, so not pushing for that right now.

@SamSaffron
Copy link
Member Author

I actually regret bubbling it from the block cause it forces you to keep repeating it which is a bit confusing. Plus if you are waiting a minute for the first few bytes from the LLM you need to bubble it right away which means you say "here is no text, but in case you need to cancel you can use this"

having it passed in gives us so much more consistency (now that endpoint/base and open ai image generation both share the pattern)

@SamSaffron SamSaffron merged commit c34fcc8 into main May 14, 2025
6 checks passed
@SamSaffron SamSaffron deleted the researcher.rb branch May 14, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants