Skip to content

[main] Source code updates from dotnet/dotnet #61745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[main] Source code updates from dotnet/dotnet #61745

wants to merge 6 commits into from
+272 −284

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 30, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners April 30, 2025 02:04
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 30, 2025
dotnet-policy-service[bot]
dotnet-policy-service bot approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@build-analysis build-analysis bot mentioned this pull request Apr 30, 2025
Open
3 tasks
@wtgodbe wtgodbe enabled auto-merge (squash) May 1, 2025 17:44
@build-analysis build-analysis bot mentioned this pull request May 2, 2025
Open
3 tasks
@wtgodbe
Copy link
Member

wtgodbe commented May 2, 2025

Got a test failure, we probably need to update the test:

Microsoft.AspNetCore.Http.ValidationsGenerator.Tests.ValidationsGeneratorTests.CanValidateTypeWithParsableProperties

Assert.Collection() Failure: Item comparison failure
↓ (pos 4)
Collection: [···, ["DecimalWithRange"] = ["Amount must be between 0.1 and 100.5"], ["TimeOnlyWithRequiredValue"] = ["The TimeOnlyWithRequiredValue field is required."], ["TimeSpanWithHourRange"] = ["Hours must be between 0 and 12"], ["Url"] = ["This operation is not supported for a relative URI"···], ["VersionWithRegex"] = ["Must be a valid version number (e.g. 1.0.0)"]]
Error: Assert.Contains() Failure: Item not found in collection
Collection: ["This operation is not supported for a relative URI"···]
Not found: "The field Url must be a valid URL."

Looks like those strings live in System.Private.Uri and System.Net.WebSockets.Client, though I don't see any relevant-looking recent changes there. @carlossanlop any idea who might know about this? maybe @MihaZupan

@MihaZupan
Copy link
Member

That's a bug in UrlAttribute from dotnet/runtime#114992, cc: @Maximys.
https://github.com/dotnet/runtime/blob/27604b57bd2e9c9aa46d005db7c4e387d461b5b6/src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/UrlAttribute.cs#L24-L26
the check for .Scheme should be preceded by .IsAbsoluteUri.

@MihaZupan MihaZupan mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @MihaZupan