-
Notifications
You must be signed in to change notification settings - Fork 6k
Update task-expressions.md #45850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task-expressions.md #45850
Conversation
Added `and!` section
@T-Gro Can you give this a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - @Lanayx would it be possible to link to the RFC/spec for how this is implemented so that users that want to understand the concurrency semantics can learn more? Something like:
For more details about this built-in support for concurrency, see RFC-1234
Also, there's a limitation involved with this current implementation, right? Might be good to have a Note:
section outlining that rough edge.
It's possible of course, I thought about it, but I'm not sure it's needed in place. I see this page as a reference for "how to use it", rather than "how does it work inside", so the link to implementation is a bit off topic in my view. Maybe adding to the links list at the bottom is a better option?
No, there are no limitations, only space to improve performance in future. I don't think we should mention it on this page. |
Agree with @Lanayx , we don't put RFC details (sometimes very low level details) into docs ;; except for a footer as related links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lanayx
This LGTM. I'll after making a minor lint fix.
Added
and!
sectionSummary
Describe your changes here.
Relates to dotnet/fsharp#18451
Internal previews