Enhancement

[kangshugang]

Made the following enhancements:

1. Add variables watch feature
2. Add call stack view and navigation feature
3. Add a break point toggle button, which works before and after the debugging started.
   i.e. Enable turn on/off break points at running time.
4. Turn on / off the input boxes for arguments and debugging commands.

[dpo]

Should the following if be removed and replaced with a call to askForPaths() then?

[kangshugang]

The change is adding the last line, which set the file to debug as the current active file.

The if is to check whether we need to stop the debugging (if the debugger is already running). This is the original code. It has nothing to do with the change.

[dpo]

What I'm saying is that, because you set debuggedFileName, the next if will never be active (pathsNotSet() will always return false).

[kangshugang]

Sorry, I misunderstood your comment.

[kangshugang]

It is up to you incorporate the changes. I am happy, as long as it works. :-)

[dpo]

I think I finally made it through your code. I created a few separate pull requests to merge it in so as to keep changes self-contained. I'm very grateful for your work and contribution! Many thanks! Next time, I'll probably be able to merge faster if you send a few small pull requests instead of a large single pull request.

I haven't yet merged the change related to the callstack. I think it's very worthy and I'd like to add it, but currently the output related to the callstack clobbers other output from the debugger.

[kangshugang]

Dominique, Thank you very much for your time and effort in reviewing me changes !!! Actually, I was trying to use Atom as a python programming tool. Indeed, I like Atom, and I like your python debugger. However, without the variable watching function, it is not as convenient as other IDE tools. Basically, I tried to enhance your python debugger to serve my own purposes. After the modification, it works well for me now. Hopefully, these changes could also benefit other people. Sorry for committing several changes together. Actually, this is the first time that I use GitHub. Thank you for your suggestions, in the future, if I will make any changes, I will try to make small self-contained changes. Thus, reviewing and merging the changes will be easier. Thanks again and best regards, Shugang

…

On Mon, Nov 6, 2017 at 10:55 PM, Dominique ***@***.***> wrote: I think I finally made it through your code. I created a few separate pull requests to merge it in so as to keep changes self-contained. I'm very grateful for your work and contribution! Many thanks! Next time, I'll probably be able to merge faster if you send a few small pull requests instead of a large single pull request. I haven't yet merged the change related to the callstack. I think it's very worthy and I'd like to add it, but currently the output related to the callstack clobbers other output from the debugger. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASe-oNKcpZnTLidCZBwecBE2HHJuxjYoks5sz9TGgaJpZM4P5SOV> .

-- Shugang Kang Email: [email protected] Phone: 614-214-2186

[dpo]

I now realize that I haven't yet gone over your new panels implementation. That looks very exciting. I'll definitely find some time to look at it carefully later this week!

[luzpaz]

@dpo any progress on this. This PR looks very promising.