ESQL: Add optimization to purge join on null merge key #127583
+240
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new logical optimization rule to purge a Join in case the merge key(s) are null. The null detection is based on recognizing a tree pattern where the join sits atop a project and/or eval which contains a reference to a null, reference which matches the join key. It works at coordinator planning level, but it's most useful locally, after insertions of nulls in the plan on detecting missing fields.
bpintea
added
>enhancement
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @bpintea, I've created a changelog YAML for you. |
bpintea
commented
Apr 30, 2025
| @@ -138,7 +138,7 @@ public String toString() { | |||
|
|
|||
| @Override | |||
| public String nodeString() { | |||
| return child.nodeString() + " AS " + name(); | |||
| return child.nodeString() + " AS " + name() + "#" + id(); | |||
There was a problem hiding this comment.
Not strictly related, but not sure why we wouldn't include the id, it's easier to track which exactly reference points to an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new logical optimization rule to purge a Join in case the merge key(s) are null. The null detection is based on recognizing a tree pattern where the join sits atop a project and/or eval which contains a reference to a null, reference which matches the join key.
It works at coordinator planning level, but it's most useful locally, after insertions of nulls in the plan on detecting missing fields.
The Join is substituted with a projection with the same attributes as the join, atop an eval with all join's right fields aliased to null.
Closes #125577.