-
-
Notifications
You must be signed in to change notification settings - Fork 408
Deprecate --yarn
support for ember new
#1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Maybe we can also look into using something like https://github.com/unjs/nypm? |
ooooo |
looks like if we set the packageManager field, nypm will do everything for us https://github.com/unjs/nypm/blob/main/src/package-manager.ts#L94C28-L94C42 |
We need to think through what this would mean for ember-cli-update. Because deprecating and removing the feature for newly generated apps is one thing, whereas forcing it on existing apps just because the blueprint support is going away would be more disruptive. |
The init command has logic to detect pnpm and yarn if no package manager is provided: https://github.com/ember-cli/ember-cli/blob/master/lib/commands/init.js#L94 |
Discussion notes from RFC review: Since we don't envision removing this feature for existing apps (no reason to force them to change package managers), this isn't strictly a normal deprecation. The goal is more to (1) emit a warning for someone generating a brand new app with |
Propose Deprecating
--yarn
support forember new
Rendered
Summary
This pull request is proposing a new RFC.
To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.
A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.
An FCP is required before merging this PR to advance to Accepted.
Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.
Exploring Stage Description
This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.
An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an
Exploring
label applied.An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.
Accepted Stage Description
To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.
If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.
When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.
Checklist to move to Exploring
S-Proposed
is removed from the PR and the labelS-Exploring
is added.Checklist to move to Accepted
Final Comment Period
label has been added to start the FCP