Skip to content

chore: use testify instead of testing in server/etcdserver #19613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

This uses testify instead of testing for t.Fatal or t.Error calls in server/etcdserver package

Related to #18972

@mmorel-35 mmorel-35 force-pushed the testifier/server/etcdserver branch 4 times, most recently from 9322d6a to 478bf0d Compare March 15, 2025 18:13
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (d6416b8) to head (5dc69b7).

Additional details and impacted files

see 40 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19613      +/-   ##
==========================================
+ Coverage   65.98%   68.78%   +2.80%     
==========================================
  Files         421      421              
  Lines       35857    35857              
==========================================
+ Hits        23659    24665    +1006     
+ Misses      10791     9762    -1029     
- Partials     1407     1430      +23     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6416b8...5dc69b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35
Copy link
Contributor Author

/assign @fuweid

@mmorel-35 mmorel-35 force-pushed the testifier/server/etcdserver branch from 478bf0d to 5dc69b7 Compare April 4, 2025 06:37
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please ask for approval from fuweid. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants