Skip to content

Assume v3 store is always not nil #19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

V3 version of #19695

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.19%. Comparing base (cc90010) to head (de5e4a5).

Files with missing lines Patch % Lines
server/etcdserver/api/membership/cluster.go 90.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/membership/storev2.go 50.53% <ø> (+5.34%) ⬆️
server/etcdserver/api/membership/cluster.go 89.12% <90.00%> (+0.42%) ⬆️

... and 62 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19698      +/-   ##
==========================================
+ Coverage   65.96%   68.19%   +2.22%     
==========================================
  Files         421      421              
  Lines       35858    35842      -16     
==========================================
+ Hits        23655    24442     +787     
+ Misses      10792     9960     -832     
- Partials     1411     1440      +29     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc90010...de5e4a5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr
Copy link
Member

ahrtr commented Apr 7, 2025

similar comment as #19695 (comment)

Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius
Copy link
Member Author

/cc @ahrtr @fuweid @siyuanfoundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants