Skip to content

chore: fix testifylint new issues #19757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 17, 2025

Description

Fixes testifylint new issues after this comment

Signed-off-by: Matthieu MOREL [email protected]

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (b90c5bc) to head (0b9d021).
Report is 21 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19757      +/-   ##
==========================================
- Coverage   68.84%   68.80%   -0.04%     
==========================================
  Files         421      421              
  Lines       35857    35857              
==========================================
- Hits        24684    24672      -12     
- Misses       9747     9758      +11     
- Partials     1426     1427       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90c5bc...0b9d021. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivanvc
Copy link
Member

ivanvc commented Apr 17, 2025

/test pull-etcd-coverage-report

@ivanvc
Copy link
Member

ivanvc commented Apr 17, 2025

@mmorel-35
Copy link
Contributor Author

Can you deal with it?
I'm on my phone, I can't amend and signoff last commit

@ivanvc
Copy link
Member

ivanvc commented Apr 17, 2025

@mmorel-35, I don't have that permission. But it can wait until you're at your keyboard :)

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 18, 2025

@ivanvc , this is now ready to go

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for splitting this out @mmorel-35

@jmhbnz jmhbnz requested a review from ivanvc April 20, 2025 07:36
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, mmorel-35, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 7f51b1b into etcd-io:main Apr 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants