-
Notifications
You must be signed in to change notification settings - Fork 10.1k
chore: fix testifylint new issues #19757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #19757 +/- ##
==========================================
- Coverage 68.84% 68.80% -0.04%
==========================================
Files 421 421
Lines 35857 35857
==========================================
- Hits 24684 24672 -12
- Misses 9747 9758 +11
- Partials 1426 1427 +1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/test pull-etcd-coverage-report |
@mmorel-35, I think we're missing: 3e2d80b#diff-43a36f19393f20580a428d317f58a6d84de9576319692e05072520e765284a01 |
Can you deal with it? |
@mmorel-35, I don't have that permission. But it can wait until you're at your keyboard :) |
Signed-off-by: Matthieu MOREL <[email protected]>
f6f9910
to
0b9d021
Compare
@ivanvc , this is now ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for splitting this out @mmorel-35
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, mmorel-35, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes testifylint new issues after this comment
Signed-off-by: Matthieu MOREL [email protected]