emit compaction pause duration metric in every compaction batch #19762
Conversation
|
Hi @miancheng7. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @miancheng7 you need to sign it off by |
Previously, the compaction pause duration metric was skipped if the number of keys was smaller than `batchNum`, leading to gaps in monitoring data. This change ensures the metric is emitted for every batch, regardless of key count. Signed-off-by: Miancheng Lin <[email protected]>
miancheng7
force-pushed
the
fixCompactionPauseMetric
branch
from
e66774b to
818dec3
Compare
|
|
cc @ahrtr @chaochn47 for visibility, thanks! |
|
@miancheng7: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 30 files with indirect coverage changes @@ Coverage Diff @@
## main #19762 +/- ##
==========================================
- Coverage 68.76% 68.76% -0.01%
==========================================
Files 421 421
Lines 35897 35858 -39
==========================================
- Hits 24686 24656 -30
+ Misses 9783 9780 -3
+ Partials 1428 1422 -6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, miancheng7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-3.6 |
|
/cherry-pick release-3.5 |
|
@ahrtr: new pull request created: #19770 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ahrtr: new pull request created: #19771 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
can you please update the changelog for 3.6 and 3.5? thx |
sure, will do |
Previously, the compaction pause duration metric was skipped if the number of keys was smaller than
batchNum, leading to gaps in monitoring data. This change ensures the metric is emitted for every batch, regardless of key count.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.