Skip to content

Draft implementation of streaming range request #19766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

Achieves better latecy and memory usage.

Tested using

go run ./tools/benchmark/ put --total 10000 --val-size 100000
go run ./tools/benchmark/ range 00000000 zzzzzzzz --total 50 --clients 5 --stream
Type Memory [GiB] Latency 50%ile Latency 90%ile Latency 95%ile
Base 1.0
NoStream 19.1 5.32 8.78 9.3
Stream Limit=100 1.3 5.3 5.48 5.5
Stream Limit based on Size 1.1 6.05 6.14 6.14

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member Author

Previous draft #12343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants