geo/intersection.c: fix intersection3 (may be optimization problem)

[YoheiKakiuchi]

Why does the test pass on arm64 ( euslisp/jskeus#561 / https://travis-ci.org/github/euslisp/jskeus/builds/680614717 )

This is likely an optimization problem.
https://github.com/euslisp/EusLisp/blob/master/lisp/geo/intersection.c#L118

x86_64 (it's correct)

(setq l0 (make-line #f(-120.0 -30.0 0.0) #f(15.0 0.0 0.0)))
(setq l1 (make-line #f(-15.0 120.0 0.0)  #f(-15.0 0.0 0.0)))

(geo::line-intersection3 (l0 . pvert) (l0 . nvert) (l1 . pvert) (l1 . nvert) 0.00001) ;; -> (0.777778 1.05556)
(geo::line-intersection3 (l1 . pvert) (l1 . nvert) (l0 . pvert) (l0 . nvert) 0.00001) ;; -> (1.05556 0.777778)

arm64 (return same value)

(setq l0 (make-line #f(-120.0 -30.0 0.0) #f(15.0 0.0 0.0)))
(setq l1 (make-line #f(-15.0 120.0 0.0)  #f(-15.0 0.0 0.0)))

(geo::line-intersection3 (l0 . pvert) (l0 . nvert) (l1 . pvert) (l1 . nvert) 0.00001) ;; -> (1.05556 1.05556)
(geo::line-intersection3 (l1 . pvert) (l1 . nvert) (l0 . pvert) (l0 . nvert) 0.00001) ;; -> (0.777778 0.777778)

[k-okada]

can we confrim by chaning URL of jskeus source at https://github.com/euslisp/EusLisp/blob/master/.travis.sh#L120 to your branch and confirm this actually works?

…

-- ◉ Kei Okada 2020年4月29日(水) 4:57 Yohei Kakiuchi <[email protected]>:

Why does the test pass on arm64 ( euslisp/jskeus#561 / https://travis-ci.org/github/euslisp/jskeus/builds/680614717 ) This is likely an optimization problem. https://github.com/euslisp/EusLisp/blob/master/lisp/geo/intersection.c#L118 x86_64 (it's correct) (setq l0 (make-line #f(-120.0 -30.0 0.0) #f(15.0 0.0 0.0))) (setq l1 (make-line #f(-15.0 120.0 0.0) #f(-15.0 0.0 0.0))) (geo::line-intersection3 (l0 . pvert) (l0 . nvert) (l1 . pvert) (l1 . nvert) 0.00001) ;; -> (0.777778 1.05556) (geo::line-intersection3 (l1 . pvert) (l1 . nvert) (l0 . pvert) (l0 . nvert) 0.00001) ;; -> (1.05556 0.777778) arm64 (return same value) (setq l0 (make-line #f(-120.0 -30.0 0.0) #f(15.0 0.0 0.0))) (setq l1 (make-line #f(-15.0 120.0 0.0) #f(-15.0 0.0 0.0))) (geo::line-intersection3 (l0 . pvert) (l0 . nvert) (l1 . pvert) (l1 . nvert) 0.00001) ;; -> (1.05556 1.05556) (geo::line-intersection3 (l1 . pvert) (l1 . nvert) (l0 . pvert) (l0 . nvert) 0.00001) ;; -> (0.777778 0.777778) ________________________________ You can view, comment on, or merge this pull request online at: #427 Commit Summary geo/intersection.c: fix intersection3 (may be optimization problem) File Changes M lisp/geo/intersection.c (2) Patch Links: https://github.com/euslisp/EusLisp/pull/427.patch https://github.com/euslisp/EusLisp/pull/427.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[YoheiKakiuchi]

Here is this PR and test-triangulation (euslisp/jskeus#561)
The tests should fail. (Tests using QEMU do not do test on jskeus)
https://travis-ci.org/github/YoheiKakiuchi/EusLisp/builds/682201965

Here is this PR and fix-triangulation (euslisp/jskeus#562)
All test passed.
https://travis-ci.org/github/YoheiKakiuchi/EusLisp/builds/682207533

[k-okada]

Thanks for commit

• added test code for intersection3 3d24d6e

• I have confirmed that your patch fix this problem

  -  numunion nu;
  +  volatile numunion nu
  

  however, if we apply this chnage, we may have to cahnge all numunion variable. On the other hand, if we look into pointer LINEINTERSECTION(ctx,n,argv), this has

EusLisp/lisp/geo/intersection.c

Lines 48 to 50 in 21a5d86

	up=makeflt(u); vp=makeflt(v);
	/* printf("%f %f\n",u,v); */
	return(cons(ctx,up,cons(ctx,vp,NIL))); } }

closed via #432