make non-ascii characters in logger messages legible #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, logger messages containing non-ascii characters are displayed as unicode escape sequences, making them illegible to anyone reading the logs.
For example,
This behavior is due to the logger module making use of
json.dumps
which by default only outputs ascii characters (see here).I added
ensure_ascii=False
to whereverjson.dumps
was used for the logger messages and now output for these logs should be legible.Let me know if there are any questions or issues 👍