-
Notifications
You must be signed in to change notification settings - Fork 46
[FirebaseAI] Add it to the nightly build process #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds FirebaseAI to the nightly build process by default, including adding it to the large packaging process. It also fixes the alphabetical ordering for some of the things resulting from the rename from VertexAI. The changes involve modifications to several build scripts and configuration files to include FirebaseAI in the build and packaging process.
Highlights
- Feature: Adds FirebaseAI to the nightly build process.
- Build Process: Modifies build scripts to include FirebaseAI in the packaging process.
- Alphabetical Ordering: Fixes alphabetical ordering issues related to the rename from VertexAI.
Changelog
Click here to see the changelog
- README.md
- Updated the list of supported library names to include 'firebaseai'.
- release_build_files/CMakeLists.txt
- Added unity_pack_file for FirebaseAIReadme.md.
- Removed duplicate unity_pack_file entry for FirebaseAIReadme.md and reordered.
- scripts/build_scripts/build_package.py
- Reordered SUPPORT_TARGETS list to place 'firebaseai' in the correct alphabetical position.
- scripts/build_scripts/build_zips.py
- Reordered SUPPORT_TARGETS and TVOS_SUPPORT_TARGETS lists to place 'firebaseai' in the correct alphabetical position.
- scripts/create_debug_export.py
- Reordered the dictionary to place 'firebaseai' in the correct alphabetical position.
- scripts/gha/integration_testing/build_testapps.json
- Added a new testapp configuration for 'firebaseai'.
- Removed duplicate testapp configuration for 'firebaseai' and reordered.
- scripts/gha/restore_secrets.py
- Reordered the dictionary to place 'firebaseai' in the correct alphabetical position.
- unity_packer/exports.json
- Added a new export configuration for 'FirebaseAI.unitypackage', including import paths, manifest details, and UPM package configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A new build target's born,
FirebaseAI joins the morn,
Scripts align with care,
In nightly builds to share,
Progress marches on, adorn.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds FirebaseAI to the nightly build process and includes it in the large packaging process. The changes look good overall, with some minor adjustments needed for alphabetical ordering and code clarity.
Summary of Findings
- Alphabetical Ordering: The pull request aims to fix alphabetical ordering in some files. Ensure that the ordering is consistent across all relevant files to maintain readability and ease of maintenance.
- Redundant Code: There's an instance of redundant code in
release_build_files/CMakeLists.txt
where theunity_pack_file
command forFirebaseAIReadme.md
is present twice. Removing the duplicate will improve code clarity. - Inconsistent Ordering in Dictionaries: In
scripts/create_debug_export.py
andscripts/gha/restore_secrets.py
, the ordering of items in the dictionaries is inconsistent. Standardizing the order (e.g., alphabetically) will enhance readability.
Merge Readiness
The pull request is almost ready for merging. Addressing the redundant code in release_build_files/CMakeLists.txt
and ensuring consistent alphabetical ordering in the specified files will make the changes more maintainable. Once these points are addressed, the pull request should be good to go. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
Description
Adds FirebaseAI to the nightly build process by default. Includes adding it to the large packaging process. Also fix the alphabetical ordering for some of the things from the rename from VertexAI.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/14896247284
Type of Change
Place an
x
the applicable box: