refactor: Block Builder Executor #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
requested review from
dvush,
ZanCorDX,
ferranbt and
metachris
as code owners
ZanCorDX
reviewed
Mar 27, 2025
| } else { | ||
| TimingsConfig::ethereum() | ||
| } | ||
| TimingsConfig::ethereum() |
There was a problem hiding this comment.
Is the comment still valid or did we deprecate some optimist compatibility?
There was a problem hiding this comment.
this was left behind by Liam, when we used the live builder from rbuilder for op-rbuilder. All optimism code in rbuilder should not be needed now
There was a problem hiding this comment.
Can you remove the comment then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
op-rbuilder changes for reth 1.3.4. Reth had some major upheavals to its payload builder and generator and this mimics the op payload builder implementation as closely as possible.
✅ I have completed the following steps:
make lintmake test