Skip to content

Fix metrics emission #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix metrics emission #594

wants to merge 1 commit into from

Conversation

cody-wang-cb
Copy link
Contributor

@cody-wang-cb cody-wang-cb commented Apr 28, 2025 •
edited
Loading

📝 Summary

For some reason ctx.metrics doesn't work for us but only self.metrics, noticing the ctx uses default, trying by passing in self.metrics.clone() instead.

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cody-wang-cb