This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Fix #352 and #353 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurd1
approved these changes
May 11, 2019
Fix breaking change introduced in algolia#352 According to the [documentation](https://github.com/algolia/algoliasearch-rails/blob/master/lib/README.md#630), using custom attributes without a custom `_changed?` method will always cause changes to push to the API. This behavior was lost in algolia#338 Fix unexpected behavior during transactions algolia#353 `@algolia_must_reindex` is reset in every validate call. This means that a record that is updated multiple times in a transaction will only be indexed if the final update marks as must reindex. Update the code so that once `@algolia_must_reindex` is marked as `true`, it remains true until explicitly unset in `algolia_perform_index_tasks`
Gasparila
force-pushed
the
kevin/fix_transaction_issues
branch
from
36facf2 to
da30909
Compare
Gasparila
force-pushed
the
kevin/fix_transaction_issues
branch
from
5987061 to
c1e28a2
Compare
|
dope! 🏆 🥇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking change introduced in algolia#352
According to the documentation,
using custom attributes without a custom
_changed?method will alwayscause changes to push to the API. This behavior was lost in algolia#338
Fix unexpected behavior during transactions algolia#353
@algolia_must_reindexis reset in every validate call. This means that a recordthat is updated multiple times in a transaction will only be indexed if the
final update marks as must reindex. Update the code so that once
@algolia_must_reindexis marked astrue, it remains true untilexplicitly unset in
algolia_perform_index_tasks