Box support as external Storage Provider #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge to beta failed, conflicted files: |
ggallotti
reviewed
Sep 30, 2019
| BoxFile.Info file = getBoxFileFromPath(externalFileName, isPrivate); | ||
| OutputStream out = new FileOutputStream(localFile); | ||
| file.getResource().download(out); | ||
| out.close(); |
There was a problem hiding this comment.
This should be closed on finally clause or by using "try with resource".
There was a problem hiding this comment.
Addressed at next commit. Didn't know the "try with resource" statement.
| String fileName = getFileNameFromPath(externalFileName); | ||
|
|
||
| BoxFile.Info fileInfo = folder.uploadFile(fileStream, fileName, file.length(), null); | ||
| fileStream.close(); |
There was a problem hiding this comment.
This should be closed on finally clause or by using "try with resource".
There was a problem hiding this comment.
Addressed at next commit. Didn't know the "try with resource" statement.
ggallotti
approved these changes
Sep 30, 2019
Cherry pick to beta failed, 0 conflicted files |
Cherry pick to beta partially success |
BETA RESET - Cherry pick to beta failed, 3 conflicted files in commit 7334f5e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of Box support as a storage provider.
Issue: 67351