GeneXus compression module #874
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta failed, 1 conflicted file in commit 594547c
|
Manual cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gxcompress/src/main/java/com/genexus/compression/GXCompressor.java
Dismissed
Show dismissed
Hide dismissed
gxcompress/src/main/java/com/genexus/compression/GXCompressor.java
Dismissed
Show dismissed
Hide dismissed
Cherry pick to beta success |
|
@iroqueta I need regular code review Thanks! |
iroqueta
reviewed
Mar 19, 2025
| import com.genexus.SdtMessages_Message; | ||
| import com.genexus.StructSdtMessages_Message; | ||
| import org.apache.commons.compress.compressors.gzip.GzipCompressorOutputStream; | ||
| import org.apache.commons.compress.compressors.gzip.GzipParameters; |
iroqueta
reviewed
Mar 19, 2025
| TarArchiveInputStream tis = new TarArchiveInputStream(Files.newInputStream(archive.toPath())); | ||
| TarArchiveEntry entry; | ||
| byte[] buffer = new byte[8192]; | ||
| while ((entry = tis.getNextTarEntry()) != null) { |
There was a problem hiding this comment.
'getNextTarEntry()' is deprecated
iroqueta
reviewed
Mar 19, 2025
| boolean isTar = false; | ||
| try (FileInputStream tempFis = new FileInputStream(tempFile); | ||
| TarArchiveInputStream testTar = new TarArchiveInputStream(tempFis)) { | ||
| TarArchiveEntry testEntry = testTar.getNextTarEntry(); |
There was a problem hiding this comment.
'getNextTarEntry()' is deprecated
iroqueta
reviewed
Mar 19, 2025
| TarArchiveInputStream tarInput = new TarArchiveInputStream(tarFis)) { | ||
|
|
||
| TarArchiveEntry entry; | ||
| while ((entry = tarInput.getNextTarEntry()) != null) { |
There was a problem hiding this comment.
'getNextTarEntry()' is deprecated
Cherry pick to beta success |
iroqueta
previously approved these changes
Mar 19, 2025
Cherry pick to beta success |
Cherry pick to beta success |
sgrampone
previously approved these changes
Apr 8, 2025
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.