Skip to content

Bump commons-compress from version 1.21 to version 1.26.0. #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump commons-compress from version 1.21 to version 1.26.0. #880

wants to merge 2 commits into from

Conversation

sgrampone
Copy link
Contributor

@sgrampone sgrampone added the dependencies Pull requests that update a dependency file label Jul 3, 2024
@sgrampone sgrampone requested a review from tomas-sexenian July 3, 2024 19:26
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

tomas-sexenian
tomas-sexenian reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tomas-sexenian tomas-sexenian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the commons-compress dependency is used in 3 modules (office, search and compress) wouldn't it be better to declare it globaly in the JavaClasses pom.xml and then reference it via something like ${compress.version}?

@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit ff1d3a7
  • pom.xml

@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@tomas-sexenian tomas-sexenian self-requested a review July 8, 2024 12:50
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-sexenian tomas-sexenian tomas-sexenian approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgrampone @genexusbot @tomas-sexenian