Skip to content

Fix feature flags in potel #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
Merged

Fix feature flags in potel #4353

merged 5 commits into from
May 5, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Apr 30, 2025

Store feature flags on the isolation scope, that is the correct place.

I also checked back with Colton about the behavior of feature flags, and having the flags on the isolation scope (meaning: one set of flags per request-response cycle) is the expected behavior.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (23eb439) to head (dfe4dde).
Report is 2 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4353      +/-   ##
==============================================
- Coverage       84.38%   84.34%   -0.05%     
==============================================
  Files             144      144              
  Lines           14638    14638              
  Branches         2329     2329              
==============================================
- Hits            12353    12346       -7     
- Misses           1558     1565       +7     
  Partials          727      727              
Files with missing lines Coverage Δ
sentry_sdk/feature_flags.py 90.62% <100.00%> (ø)

... and 2 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review April 30, 2025 14:56
@antonpirker antonpirker requested a review from a team as a code owner April 30, 2025 14:56
@antonpirker antonpirker merged commit 060b2cf into potel-base May 5, 2025
125 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/flags branch May 5, 2025 08:20
antonpirker added a commit that referenced this pull request May 5, 2025
Feature flags should life on the isolation Scope. This has been first
[implemented in SDK
3.0](#4353) and is now
back ported to 2.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants