gitk: small quality of life improvements for themed Tk #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a widget factory that works for both plain Tk and themed Tk. Signed-off-by: Christoph Sommer <[email protected]>
Ignore the uicolor preference not just for win32, but also whenever themed Tk is used. On themed Tk it was frequently only changing the background of only a few select widgets rather than everything - and the default uicolor was frequently not the background color that themed Tk used for its widgets, resulting in a messy looking UI (mostly light gray, with random widgets surrounded by darker gray borders) Signed-off-by: Christoph Sommer <[email protected]>
Add a custom sash (grab/resize handle) where the window is split into panes when using themed Tk as. Other than native Tk which draws sashes by default, themed Tk does not, by default, render such handles leaving users to guess where to click to start resizing window panes. The color used for drawing these is uicolor, which is not needed on themed Tk, allowing the user to make these elements as pronounced or as invisible as desired. Signed-off-by: Christoph Sommer <[email protected]>
|
/preview |
|
Preview email sent as [email protected] |
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three closely related patches build on https://lore.kernel.org/git/[email protected] to:
cc: Johannes Sixt [email protected]