Implement GPG related api #36
Conversation
| @@ -0,0 +1,67 @@ | |||
| // Copyright 2015 The Gogs Authors. All rights reserved. | |||
|
LGTM |
| // GPGKeyEmail a email attache to a GPGKey | ||
| type GPGKeyEmail struct { | ||
| Email string `json:"email"` | ||
| //Verified bool `json:"verified"` |
There was a problem hiding this comment.
It's in the github api format but i don't know if in gitea we should/could present it. Maybe an other solution could be to uncomment it and add omitempty ?
There was a problem hiding this comment.
We could supply it, so you could just uncomment it
|
As said on gitter, I hesitate to use PublicGPG... in place of GPG... since it will only contain the public part of the keys like the ssh keys. I don't know what you think of it. |
|
Could we give an option to let user chose and we can use one as default? |
|
@lunny You are saying to let the possibility to users to add a private gpg key to gitea ? From my point of view it would not be a good idea normally you limit the existence of your gpg keys only on trusted media. My question was just for the format of object and function name to be as https://github.com/go-gitea/go-sdk/blob/master/gitea/user_key.go#L15 since it's the same case (gitea only need the public key) |
|
I think that GPG is clear enough, since we don't have the private key |
|
Ok perfect i will stick with this to continue in the next part (API and UI) in gitea. |
|
LGTM |
|
@sapk Is this done? |
|
It follows the spec so I'm merging it anyway 😂 |
In order to implement go-gitea/gitea#425
I added all the api call that should be implemented and struct needed to format requests and responses.
I follow the github format as a example: https://developer.github.com/v3/users/gpg_keys/