Enhance: Add ability to do inline prompting to choose oauth/pat #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
approved these changes
Mar 27, 2025
thedadams
reviewed
Mar 28, 2025
| Name string `json:"name,omitempty"` | ||
| Sensitive *bool `json:"sensitive,omitempty"` | ||
| Description string `json:"description,omitempty"` | ||
| Options []string `json:"options,omitempty"` |
There was a problem hiding this comment.
I've tried to keep the SDKs well-tested. Please add a test case for this.
There was a problem hiding this comment.
@thedadams Added a test for this. It will likely fail until we have the new build for gptscript
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
inline-prompting
branch
from
97b9c9d to
5df35b4
Compare
StrongMonkey
commented
Mar 28, 2025
| @@ -160,7 +160,7 @@ func TestCancelRun(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestAbortChatCompletionRun(t *testing.T) { | |||
| tool := ToolDef{Instructions: "What is the capital of the united states?"} | |||
| tool := ToolDef{Instructions: "Generate a real long essay about the meaning of life."} | |||
There was a problem hiding this comment.
I have to fix this. It is flaky and will fail the test if the message are sent in one event
thedadams
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to a field to indicate whether this field can be option/select styles.