Use Base.o_* instead of raw {#const O_*}
#339
Draft
+27
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set to draft while https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13856 is in progress |
`stage1` cross compilers could use different values instead of system-defined. GHC JS Backend change these constants to be compatible with Node.js environment.
|
It became actual after https://gitlab.haskell.org/ghc/ghc/-/issues/25190 Which were raised after These changes are for restoring consistency across cross compile targets with packages which have custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stage1cross compilers can use different values instead of system-defined. GHC JS Backend overrides these constants to be compatible with Node.js environment.Details of investigation.
Interface stability tests have the following overridden constants: