Skip to content

HHH-19324 - Switch tests using hbm.xml to use mapping.xml #10116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HHH-19324 - Switch tests using hbm.xml to use mapping.xml #10116

wants to merge 1 commit into from

Conversation

sebersole
Copy link
Member

@sebersole sebersole commented May 7, 2025 •
edited by hibernate-github-bot bot
Loading

HHH-19324 - Switch tests using hbm.xml to use mapping.xml
HHH-19433 - Deprecate @PropertyRef

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-19324

github-advanced-security[bot]
github-advanced-security bot found potential problems May 7, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/A.java
this.hs = hs;
}

public Set getHs()
{
public Set getHs() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/A.java
}

public String toString()
{
public String toString() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
Object.toString
Loading
; it is advisable to add an Override annotation.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/G.java
this.a = a;
}

public Set getHs()
{
public Set getHs() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
getHs exposes the internal representation stored in field hs. The value may be modified
after this call to getHs
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/H.java
this.a = a;
}

public Set getGs()
{
public Set getGs() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getGs exposes the internal representation stored in field gs. The value may be modified
after this call to getGs
Loading
.
getGs exposes the internal representation stored in field gs. The value may be modified
after this call to getGs
Loading
.
getGs exposes the internal representation stored in field gs. The value may be modified
after this call to getGs
Loading
.
getGs exposes the internal representation stored in field gs. The value may be modified
after this call to getGs
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/circle/Node.java
private String transientField = "node original value";

public Set getDeliveryTransports() {
public Set<Transport> getDeliveryTransports() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
getDeliveryTransports exposes the internal representation stored in field deliveryTransports. The value may be modified
after this call to getDeliveryTransports
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/circle/Tour.java
@@ -43,15 +38,11 @@
this.name = name;
}

public Set getNodes() {
public Set<Node> getNodes() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
getNodes exposes the internal representation stored in field nodes. The value may be modified
after this call to getNodes
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/cascade/circle/Vehicle.java
@@ -41,11 +61,11 @@
this.version = version;
}

public Set getTransports() {
public Set<Transport> getTransports() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getTransports exposes the internal representation stored in field transports. The value may be modified
after this call to getTransports
Loading
.
getTransports exposes the internal representation stored in field transports. The value may be modified
after this call to getTransports
Loading
.
getTransports exposes the internal representation stored in field transports. The value may be modified
after this call to getTransports
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/component/basic/Employee.java
@@ -51,11 +51,11 @@
this.optionalComponent = optionalComponent;
}

public Set getDirectReports() {
public Set<Employee> getDirectReports() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getDirectReports exposes the internal representation stored in field directReports. The value may be modified
after this call to getDirectReports
Loading
.
.../org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java
session.close();
factoryScope.inTransaction( (session ) -> {
Definition definition = new Definition( 1, "stuff" );
Value value1 = new Value( 1, definition );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Value value1' is never read.
...ate-core/src/test/java/org/hibernate/orm/test/component/cascading/collection/Definition.java
this.name = name;
}

public Set<Value> getValues() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getValues exposes the internal representation stored in field values. The value may be modified
after this call to getValues
Loading
.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 8, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/deletetransient/Address.java
@@ -39,11 +39,11 @@
this.info = info;
}

public Set getSuites() {
public Set<Suite> getSuites() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
getSuites exposes the internal representation stored in field suites. The value may be modified
after this call to getSuites
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/deletetransient/Person.java
@@ -42,19 +42,19 @@
this.name = name;
}

public Set getAddresses() {
public Set<Address> getAddresses() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
getAddresses exposes the internal representation stored in field addresses. The value may be modified
after this call to getAddresses
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/deletetransient/Person.java
this.addresses = addresses;
}

public Collection getFriends() {
public Collection<Person> getFriends() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getFriends exposes the internal representation stored in field friends. The value may be modified
after this call to getFriends
Loading
.
getFriends exposes the internal representation stored in field friends. The value may be modified
after this call to getFriends
Loading
.
getFriends exposes the internal representation stored in field friends. The value may be modified
after this call to getFriends
Loading
.
getFriends exposes the internal representation stored in field friends. The value may be modified
after this call to getFriends
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/deletetransient/Suite.java
@@ -38,11 +38,11 @@
this.location = location;
}

public Set getNotes() {
public Set<Note> getNotes() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getNotes exposes the internal representation stored in field notes. The value may be modified
after this call to getNotes
Loading
.
getNotes exposes the internal representation stored in field notes. The value may be modified
after this call to getNotes
Loading
.
@sebersole sebersole force-pushed the drop-hbm branch 4 times, most recently from fc8040f to 27fa0e2 Compare May 8, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebersole