Skip to content

[SYCL][clang-linker-wrapper] Replace -lto-emit-asm option with -S for cuda pipeline #18000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,7 @@ Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args,
CmdArgs.push_back("-Wl,--no-undefined");

if (IsSYCLKind && Triple.isNVPTX())
CmdArgs.push_back("-Wl,--lto-emit-asm");
CmdArgs.push_back("-S");
for (StringRef InputFile : InputFiles)
CmdArgs.push_back(InputFile);

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/NewOffloadDriver/multisource.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: true
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17812
// Separate kernel sources and host code sources
// Test with `--offload-new-driver`
// RUN: %{build} --offload-new-driver -c -o %t.kernel.o -DINIT_KERNEL -DCALC_KERNEL
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/NewOffloadDriver/split-per-source-main.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// UNSUPPORTED: true
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17812
// RUN: %{build} -Wno-error=unused-command-line-argument -fsycl-device-code-split=per_source -I %S/Inputs -o %t.out %S/Inputs/split-per-source-second-file.cpp \
// RUN: --offload-new-driver -fsycl-dead-args-optimization
// RUN: %{run} %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// UNSUPPORTED: true
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17812
// Test with `--offload-new-driver`
// RUN: %{build} -DSOURCE1 --offload-new-driver -c -o %t1.o
// RUN: %{build} -DSOURCE2 --offload-new-driver -c -o %t2.o
Expand Down