Skip to content

[SYCL][Driver]Enable multiple third-party targets for SYCL AOT. #18145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: sycl
Choose a base branch
from

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Apr 22, 2025

This patch enables -fsycl-targets option to support a comma-separated list of NVidia and AMD Processor Graphics values as target triple values for the SYCL AOT flow.

Example:

clang++  -###  -fsycl  -fsycl-targets=nvidia_gpu_sm_60,nvidia_gpu_sm_70  syclfile.cpp
clang++  -###  -fsycl  -fsycl-targets=amd_gpu_gfx90a,amd_gpu_gfx90c      syclfile.cpp

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - are there plans on updating documentation to allow for multiple target support?

@dm-vodopyanov
Copy link
Contributor

From the PR description:

clang++  -###  -fsycl  -fsycl-targets=nvidia_gpu_sm_60, nvidia_gpu_sm_70  syclfile.cpp
clang++  -###  -fsycl  -fsycl-targets=amd_gpu_gfx90a, amd_gpu_gfx90c      syclfile.cpp

I assume there should be no space between values in -fsycl-targets option? If not, please update the description

@srividya-sundaram
Copy link
Contributor Author

From the PR description:

clang++  -###  -fsycl  -fsycl-targets=nvidia_gpu_sm_60, nvidia_gpu_sm_70  syclfile.cpp
clang++  -###  -fsycl  -fsycl-targets=amd_gpu_gfx90a, amd_gpu_gfx90c      syclfile.cpp

I assume there should be no space between values in -fsycl-targets option? If not, please update the description

I added some extra space for readability purposes but I have removed the spaces now in the description.

Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Signed-off-by: srividya sundaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants