Skip to content

docs(cli): clarify that the CLI and Framework versions are not the same #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2025
Merged

docs(cli): clarify that the CLI and Framework versions are not the same #4064

merged 6 commits into from
May 9, 2025
+2 −2

Conversation

elcreator
Copy link
Contributor

Docs v8 says it will install v8 but it installs v7 as v8 cli was never released.

@elcreator
Specified current major version
2f21b30 
Docs v8 says it will install v8 but it installs v7 as v8 cli was never released.
@elcreator elcreator requested a review from a team as a code owner April 3, 2025 18:26
@elcreator elcreator requested a review from brandyscarney April 3, 2025 18:26
@vercel Vercel
Copy link

vercel bot commented Apr 3, 2025

@elcreator is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@ShaneK
Copy link
Member

ShaneK commented Apr 4, 2025 •
edited
Loading

I don't see a reason for specifically calling out the Ionic CLI is v7 right now. The command provided installs the latest version of the Ionic CLI, which has no version association with Ionic Framework or Capacitor. It was coincidentally the same major version as Ionic Framework for a bit, but that was more of a coincidence than anything done intentionally.

I believe this change would incur unnecessary maintenance in the future if the Ionic CLI releases another major version and I don't see any benefit in mentioning it here.

@elcreator
Copy link
Contributor Author

elcreator commented Apr 4, 2025 •
edited
Loading

Including at least statement about different versions of CLI and Ionic will be helpful, as people see here v8 and upgrade to v8 which is misleading:
image
As many Angular developers prefer Ionic they may assume the CLI version is bigger (as in Angular) or equal (as in many other npm packets) but not lower than version of thing it is intended to install.

@elcreator elcreator changed the title Specified current major version Ionic CLI and Ionic current major version mismatch Apr 5, 2025
@vercel Vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 7:44pm

@ShaneK ShaneK changed the title Ionic CLI and Ionic current major version mismatch docs(cli): Ionic CLI and Ionic current major version clarification May 9, 2025
@ShaneK ShaneK enabled auto-merge (squash) May 9, 2025 18:54
@ShaneK ShaneK disabled auto-merge May 9, 2025 18:54
@ShaneK ShaneK enabled auto-merge (squash) May 9, 2025 19:28
@brandyscarney brandyscarney disabled auto-merge May 9, 2025 19:39
@brandyscarney brandyscarney changed the title docs(cli): Ionic CLI and Ionic current major version clarification docs(cli): clarify that the CLI and Framework versions are not the same May 9, 2025
@brandyscarney brandyscarney merged commit 458b84a into ionic-team:main May 9, 2025
4 checks passed
@ShaneK
Copy link
Member

ShaneK commented May 9, 2025

Thank you for your contribution, congratulations on your first pull request to Ionic Docs! Your PR has been merged and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneK ShaneK ShaneK approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elcreator @ShaneK @brandyscarney